Persist channel DRED settings

src/VoiceCat.Server/ChannelManagement.cs

@@ -65,9 +65,9 @@ public sealed partial class VoiceServer
             Encoding.UTF8.GetByteCount(channel.Topic) > 4096 || Encoding.UTF8.GetByteCount(password) > 1024 || !Enum.IsDefined(channel.Type) ||
             channel.MaxUsers > int.MaxValue || a is null || a.Codec != 0 || !Enum.IsDefined(a.Mode) || !Enum.IsDefined(a.Application) ||
             a.SampleRate != 48000 || a.BitrateBps is < 500 or > 512000 || a.FrameMs is not (5 or 10 or 20 or 40 or 60) ||
-            a.Complexity > 10 || a.ExpectedPacketLoss > 100 || a.Dred ||
+            a.Complexity > 10 || a.ExpectedPacketLoss > 100 ||
             !create && !channels.Any(c => c.Id == channel.Id) || channel.ParentId != 0 && !channels.Any(c => c.Id == channel.ParentId))
-            throw new ArgumentException("Invalid channel or audio configuration (database v2 cannot persist DRED).");
+            throw new ArgumentException("Invalid channel or audio configuration.");
         if (channel.Id == 1 && !create && (password.Length != 0 || channel.ParentId != 0)) throw new ArgumentException("Lobby must remain an unprotected root channel.");
         uint parent = channel.ParentId;
         var visited = new HashSet<uint>();

src/VoiceCat.Server/Data/AccountStore.cs

@@ -27,13 +27,21 @@ public sealed partial class AccountStore : IDisposable
         version.Transaction = transaction;
         version.CommandText = "SELECT value FROM server_meta WHERE key='schema_version'";
         object? stored = version.ExecuteScalar();
-        if (stored is not null && (!int.TryParse((string)stored, NumberStyles.None, CultureInfo.InvariantCulture, out int revision) || revision is < 1 or > 2))
+        int revision = 0;
+        if (stored is not null && (!int.TryParse((string)stored, NumberStyles.None, CultureInfo.InvariantCulture, out revision) || revision is < 1 or > 3))
             throw new InvalidDataException("Unsupported server database schema version.");
         using var resource = typeof(AccountStore).Assembly.GetManifestResourceStream("VoiceCat.Server.Data.schema.sql")!;
         using var reader = new StreamReader(resource);
         using var migrate = connection.CreateCommand();
         migrate.Transaction = transaction;
-        migrate.CommandText = reader.ReadToEnd() + "INSERT INTO server_meta (key,value) VALUES ('schema_version','2') ON CONFLICT(key) DO UPDATE SET value='2';";
+        migrate.CommandText = reader.ReadToEnd();
+        migrate.ExecuteNonQuery();
+        if (stored is not null && revision < 3)
+        {
+            migrate.CommandText = "ALTER TABLE channels ADD COLUMN audio_dred INTEGER NOT NULL DEFAULT 0;";
+            migrate.ExecuteNonQuery();
+        }
+        migrate.CommandText = "INSERT INTO server_meta (key,value) VALUES ('schema_version','3') ON CONFLICT(key) DO UPDATE SET value='3';";
         migrate.ExecuteNonQuery();
         transaction.Commit();
     }
@@ -121,7 +129,7 @@ public sealed partial class AccountStore : IDisposable
         command.CommandText = """
             SELECT id,parent_id,name,topic,password_hash,max_users,type,sort_order,
             audio_codec,audio_mode,audio_sample_rate,audio_bitrate_bps,audio_frame_ms,
-            audio_application,audio_fec,audio_expected_packet_loss,audio_dtx,audio_complexity
+            audio_application,audio_fec,audio_expected_packet_loss,audio_dtx,audio_complexity,audio_dred
             FROM channels ORDER BY sort_order,id
             """;
         using var reader = command.ExecuteReader();
@@ -139,7 +147,7 @@ public sealed partial class AccountStore : IDisposable
                     SampleRate = checked((uint)reader.GetInt64(10)), BitrateBps = checked((uint)reader.GetInt64(11)),
                     FrameMs = checked((uint)reader.GetInt64(12)), Application = (Voicecat.V1.OpusApplication)reader.GetInt32(13),
                     Fec = reader.GetInt32(14) != 0, ExpectedPacketLoss = checked((uint)reader.GetInt64(15)),
-                    Dtx = reader.GetInt32(16) != 0, Complexity = checked((uint)reader.GetInt64(17))
+                    Dtx = reader.GetInt32(16) != 0, Complexity = checked((uint)reader.GetInt64(17)), Dred = reader.GetInt32(18) != 0
                 }
             });
         }

src/VoiceCat.Server/Data/ChannelStore.cs

@@ -43,9 +43,9 @@ public sealed partial class AccountStore
             byte[] salt = RandomNumberGenerator.GetBytes(16);
             hash = Convert.ToHexString(salt).ToLowerInvariant() + ":" + Convert.ToHexString(ChannelDigest(password, salt)).ToLowerInvariant();
         }
-        string[] columns = ["parent_id", "name", "topic", "max_users", "type", "sort_order", "audio_codec", "audio_mode", "audio_sample_rate", "audio_bitrate_bps", "audio_frame_ms", "audio_application", "audio_fec", "audio_expected_packet_loss", "audio_dtx", "audio_complexity"];
+        string[] columns = ["parent_id", "name", "topic", "max_users", "type", "sort_order", "audio_codec", "audio_mode", "audio_sample_rate", "audio_bitrate_bps", "audio_frame_ms", "audio_application", "audio_fec", "audio_expected_packet_loss", "audio_dtx", "audio_complexity", "audio_dred"];
         var a = channel.Audio;
-        object[] values = [channel.ParentId, channel.Name, channel.Topic, channel.MaxUsers, (int)channel.Type, channel.Order, a.Codec, (int)a.Mode, a.SampleRate, a.BitrateBps, a.FrameMs, (int)a.Application, a.Fec, a.ExpectedPacketLoss, a.Dtx, a.Complexity];
+        object[] values = [channel.ParentId, channel.Name, channel.Topic, channel.MaxUsers, (int)channel.Type, channel.Order, a.Codec, (int)a.Mode, a.SampleRate, a.BitrateBps, a.FrameMs, (int)a.Application, a.Fec, a.ExpectedPacketLoss, a.Dtx, a.Complexity, a.Dred];
         for (int i = 0; i < columns.Length; i++) command.Parameters.AddWithValue("$" + columns[i], values[i]);
         command.Parameters.AddWithValue("$hash", hash);
         command.Parameters.AddWithValue("$id", channel.Id);

src/VoiceCat.Server/Data/schema.sql

@@ -25,6 +25,7 @@ CREATE TABLE IF NOT EXISTS channels (
     audio_expected_packet_loss INTEGER NOT NULL DEFAULT 10,
     audio_dtx INTEGER NOT NULL DEFAULT 1,
     audio_complexity INTEGER NOT NULL DEFAULT 5,
+    audio_dred INTEGER NOT NULL DEFAULT 0,
     sort_order INTEGER NOT NULL DEFAULT 0
 );
 CREATE TABLE IF NOT EXISTS bans (