Three bugs fixed across the full stack (proto/server/core/ABI/Win/macOS/iOS): 1. Join/Leave Voice now truly subscribes/unsubscribes from the voice plane. Previously the button only toggled the local mic — receiving was always on (gated by channel membership alone). Added a protocol-level voice subscription concept: new SubscribeVoiceRequest/UnsubscribeVoiceRequest/VoiceSubscriptionResult proto messages, User.voice_subscribed field, vc_join_voice/vc_leave_voice C ABI functions, VC_EVENT_VOICE_STATE event, server-side voice_subscribed flag checked by the SFU relay recipient filter, and core-client gating of remote-stream decoder setup. All three clients rewired to subscribe+mic on Join / unsubscribe on Leave. Text chat works regardless of voice subscription. 2. Channel edit dialog now shows the channel's actual current settings. The read struct vc_channel was missing sort_order and audio fields — only the write struct vc_channel_info had them. Extended vc_channel with both (additive, no ABI break), updated the session model and list_channels marshaling to populate them, and updated all three clients' edit callers to use actual channel info instead of hardcoded defaults. 3. Channel parameter updates now automatically restart everyone's streams. Previously editing a channel's audio config persisted and broadcast a ChannelEvent::UPDATED, but no layer restarted streams — encoders/decoders are frozen at announce time. handle_channel_event now detects audio-config changes on the user's current channel and stop->starts each active local stream. The server reads the updated config on re-announce; peers wire up fresh decoders at the new ssrc. All 29 CTest tests pass; Windows DLL + C# client build clean. Apple clients not yet compile-verified (Windows environment).
79 lines
1.7 KiB
C#
79 lines
1.7 KiB
C#
// Plain managed record types — what survives past the native struct/free-list lifetime
|
|
// (Marshaling.cs converts the native *Native structs into these and immediately frees the
|
|
// native list). Nothing here holds an IntPtr.
|
|
namespace VoiceCat.Interop;
|
|
|
|
public sealed record ChannelInfo(
|
|
uint Id,
|
|
uint ParentId,
|
|
string Name,
|
|
string Topic,
|
|
bool PasswordProtected,
|
|
uint MaxUsers,
|
|
uint SortOrder,
|
|
AudioConfigInfo Audio);
|
|
|
|
public sealed record ChannelEditInfo(
|
|
uint Id,
|
|
uint ParentId,
|
|
string Name,
|
|
string Topic,
|
|
bool PasswordProtected,
|
|
string? Password,
|
|
uint MaxUsers,
|
|
uint SortOrder,
|
|
AudioConfigInfo Audio);
|
|
|
|
public sealed record UserInfo(
|
|
uint Id,
|
|
string Nickname,
|
|
bool IsGuest,
|
|
uint ChannelId,
|
|
bool SelfMicMuted,
|
|
bool SelfDeafened,
|
|
bool ServerMuted,
|
|
bool ServerDeafened,
|
|
bool VoiceSubscribed);
|
|
|
|
public sealed record PermissionsInfo(
|
|
bool CanCreateTempChannel,
|
|
bool CanKick,
|
|
bool CanBan,
|
|
bool CanMoveUsers,
|
|
bool CanAdminAccounts,
|
|
bool IsAdmin);
|
|
|
|
public sealed record AccountInfo(
|
|
string Username,
|
|
bool IsAdmin,
|
|
ulong CreatedAtUnixMs,
|
|
ulong LastLoginUnixMs);
|
|
|
|
public sealed record StreamSummary(
|
|
uint StreamId,
|
|
VcStreamKind Kind,
|
|
string Label);
|
|
|
|
public sealed record RemoteStreamState(
|
|
float Gain,
|
|
bool Muted,
|
|
bool NoiseReduction);
|
|
|
|
public sealed record DeviceInfo(
|
|
string Id,
|
|
string Name,
|
|
bool IsDefault);
|
|
|
|
public sealed record AudioConfigInfo(
|
|
uint Codec,
|
|
bool Stereo,
|
|
uint SampleRate,
|
|
uint BitrateBps,
|
|
uint FrameMs,
|
|
uint Application,
|
|
bool Fec,
|
|
uint ExpectedPacketLoss,
|
|
bool Dtx,
|
|
uint Complexity,
|
|
bool Dred);
|