Talon/chat_grid
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename widget emitSoundSpeed property

Browse Source
This commit is contained in:
Jage9
2026-02-21 23:10:17 -05:00
parent dd06d882e7
commit d3a98ef1ea
8 changed files with 23 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
server/app/items/widget.py
View File

@@ -17,7 +17,7 @@ EDITABLE_PROPERTIES: tuple[str, ...] = (
"facing",
"emitRange",
"emitVolume",
"emitSpeed",
"emitSoundSpeed",
"emitEffect",
"emitEffectValue",
"useSound",
@@ -36,7 +36,7 @@ DEFAULT_PARAMS: dict = {
"facing": 0,
"emitRange": 15,
"emitVolume": 100,
"emitSpeed": 50,
"emitSoundSpeed": 50,
"emitEffect": "off",
"emitEffectValue": 50,
"useSound": "",
@@ -63,7 +63,7 @@ PROPERTY_METADATA: dict[str, dict[str, object]] = {
"tooltip": "Emitted sound volume percent.",
"range": {"min": 0, "max": 100, "step": 1},
},
"emitSpeed": {
"emitSoundSpeed": {
"valueType": "number",
"tooltip": "Playback speed/pitch percent for emitted sound. 50 is normal, 0 is half, 100 is double.",
"range": {"min": 0, "max": 100, "step": 1},
@@ -132,12 +132,12 @@ def validate_update(item: WorldItem, next_params: dict) -> dict:
next_params["emitVolume"] = emit_volume
try:
emit_speed = int(next_params.get("emitSpeed", item.params.get("emitSpeed", 50)))
emit_speed = int(next_params.get("emitSoundSpeed", item.params.get("emitSoundSpeed", 50)))
except (TypeError, ValueError) as exc:
raise ValueError("emitSpeed must be an integer between 0 and 100.") from exc
raise ValueError("emitSoundSpeed must be an integer between 0 and 100.") from exc
if not (0 <= emit_speed <= 100):
raise ValueError("emitSpeed must be between 0 and 100.")
next_params["emitSpeed"] = emit_speed
raise ValueError("emitSoundSpeed must be between 0 and 100.")
next_params["emitSoundSpeed"] = emit_speed
emit_effect = str(next_params.get("emitEffect", item.params.get("emitEffect", "off"))).strip().lower()
if emit_effect not in EFFECT_OPTIONS:

8
server/tests/test_item_use_cooldown.py
View File

@@ -292,7 +292,7 @@ async def test_widget_update_and_use(monkeypatch: pytest.MonkeyPatch) -> None:
"facing": 123.4,
"emitRange": 7,
"emitVolume": 42,
"emitSpeed": 25,
"emitSoundSpeed": 25,
"emitEffect": "reverb",
"emitEffectValue": 63.2,
"useSound": "ping.ogg",
@@ -306,7 +306,7 @@ async def test_widget_update_and_use(monkeypatch: pytest.MonkeyPatch) -> None:
assert item.params.get("facing") == 123.4
assert item.params.get("emitRange") == 7
assert item.params.get("emitVolume") == 42
assert item.params.get("emitSpeed") == 25
assert item.params.get("emitSoundSpeed") == 25
assert item.params.get("emitEffect") == "reverb"
assert item.params.get("emitEffectValue") == 63.2
assert item.params.get("useSound") == "sounds/ping.ogg"
@@ -326,7 +326,7 @@ async def test_widget_update_and_use(monkeypatch: pytest.MonkeyPatch) -> None:
await server._handle_message(
client,
json.dumps({"type": "item_update", "itemId": item.id, "params": {"emitSpeed": 101}}),
json.dumps({"type": "item_update", "itemId": item.id, "params": {"emitSoundSpeed": 101}}),
)
assert send_payloads[-1].ok is False
assert "emitspeed must be between 0 and 100" in send_payloads[-1].message.lower()
assert "emitsoundspeed must be between 0 and 100" in send_payloads[-1].message.lower()