Talon/chat_grid
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: remove per-type module.py and simplify plugin wiring

Browse Source
This commit is contained in:
Jage9
2026-02-24 18:56:42 -05:00
parent fcb5e85b13
commit 3c52d35983
27 changed files with 75 additions and 366 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/app/items/types/clock/__init__.py
View File

@@ -1,3 +1 @@
"""Item type package exposing plugin module surface."""
from .module import * # noqa: F401,F403
"""Clock item type plugin package."""

41
server/app/items/types/clock/module.py
View File

@@ -1,41 +0,0 @@
"""Clock item plugin module surface."""
from __future__ import annotations
from .actions import use_item
from .definition import (
CAPABILITIES,
DEFAULT_PARAMS,
DEFAULT_TIME_ZONE,
DEFAULT_TITLE,
DIRECTIONAL,
EDITABLE_PROPERTIES,
EMIT_RANGE,
EMIT_SOUND,
LABEL,
PROPERTY_METADATA,
TIME_ZONE_OPTIONS,
TOOLTIP,
USE_COOLDOWN_MS,
USE_SOUND,
)
from .validator import validate_update
__all__ = [
"LABEL",
"TOOLTIP",
"EDITABLE_PROPERTIES",
"CAPABILITIES",
"USE_SOUND",
"EMIT_SOUND",
"USE_COOLDOWN_MS",
"EMIT_RANGE",
"DIRECTIONAL",
"DEFAULT_TITLE",
"DEFAULT_TIME_ZONE",
"TIME_ZONE_OPTIONS",
"DEFAULT_PARAMS",
"PROPERTY_METADATA",
"validate_update",
"use_item",
]

5
server/app/items/types/clock/plugin.py
View File

@@ -2,10 +2,11 @@
from __future__ import annotations
from . import module
from ..plugin_helpers import build_item_module
from . import actions, definition, validator
ITEM_TYPE_PLUGIN = {
"type": "clock",
"order": 10,
"module": module,
"module": build_item_module(definition, validate_update=validator.validate_update, use_item=actions.use_item),
}

4
server/app/items/types/dice/__init__.py
View File

@@ -1,3 +1 @@
"""Item type package exposing plugin module surface."""
from .module import * # noqa: F401,F403
"""Dice item type plugin package."""

37
server/app/items/types/dice/module.py
View File

@@ -1,37 +0,0 @@
"""Dice item plugin module surface."""
from __future__ import annotations
from .actions import use_item
from .definition import (
CAPABILITIES,
DEFAULT_PARAMS,
DEFAULT_TITLE,
DIRECTIONAL,
EDITABLE_PROPERTIES,
EMIT_RANGE,
EMIT_SOUND,
LABEL,
PROPERTY_METADATA,
TOOLTIP,
USE_COOLDOWN_MS,
USE_SOUND,
)
from .validator import validate_update
__all__ = [
"LABEL",
"TOOLTIP",
"EDITABLE_PROPERTIES",
"CAPABILITIES",
"USE_SOUND",
"EMIT_SOUND",
"USE_COOLDOWN_MS",
"EMIT_RANGE",
"DIRECTIONAL",
"DEFAULT_TITLE",
"DEFAULT_PARAMS",
"PROPERTY_METADATA",
"validate_update",
"use_item",
]

5
server/app/items/types/dice/plugin.py
View File

@@ -2,10 +2,11 @@
from __future__ import annotations
from . import module
from ..plugin_helpers import build_item_module
from . import actions, definition, validator
ITEM_TYPE_PLUGIN = {
"type": "dice",
"order": 20,
"module": module,
"module": build_item_module(definition, validate_update=validator.validate_update, use_item=actions.use_item),
}

4
server/app/items/types/piano/__init__.py
View File

@@ -1,3 +1 @@
"""Item type package exposing plugin module surface."""
from .module import * # noqa: F401,F403
"""Piano item type plugin package."""

41
server/app/items/types/piano/module.py
View File

@@ -1,41 +0,0 @@
"""Piano item plugin module surface."""
from __future__ import annotations
from .actions import use_item
from .definition import (
CAPABILITIES,
DEFAULT_PARAMS,
DEFAULT_TITLE,
DIRECTIONAL,
EDITABLE_PROPERTIES,
EMIT_RANGE,
EMIT_SOUND,
INSTRUMENT_OPTIONS,
LABEL,
PROPERTY_METADATA,
TOOLTIP,
USE_COOLDOWN_MS,
USE_SOUND,
VOICE_MODE_OPTIONS,
)
from .validator import validate_update
__all__ = [
"LABEL",
"TOOLTIP",
"EDITABLE_PROPERTIES",
"CAPABILITIES",
"USE_SOUND",
"EMIT_SOUND",
"USE_COOLDOWN_MS",
"EMIT_RANGE",
"DIRECTIONAL",
"DEFAULT_TITLE",
"DEFAULT_PARAMS",
"PROPERTY_METADATA",
"INSTRUMENT_OPTIONS",
"VOICE_MODE_OPTIONS",
"validate_update",
"use_item",
]

5
server/app/items/types/piano/plugin.py
View File

@@ -2,10 +2,11 @@
from __future__ import annotations
from . import module
from ..plugin_helpers import build_item_module
from . import actions, definition, validator
ITEM_TYPE_PLUGIN = {
"type": "piano",
"order": 30,
"module": module,
"module": build_item_module(definition, validate_update=validator.validate_update, use_item=actions.use_item),
}

19
server/app/items/types/plugin_helpers.py Normal file
View File

@@ -0,0 +1,19 @@
"""Helpers for composing item plugin module surfaces."""
from __future__ import annotations
from types import SimpleNamespace
from typing import Any
def build_item_module(definition: Any, *, validate_update: Any, use_item: Any) -> Any:
"""Compose a plugin module-like object from split definition/validator/actions files."""
exports: dict[str, Any] = {
name: getattr(definition, name)
for name in dir(definition)
if name.isupper()
}
exports["validate_update"] = validate_update
exports["use_item"] = use_item
return SimpleNamespace(**exports)

4
server/app/items/types/radio_station/__init__.py
View File

@@ -1,3 +1 @@
"""Item type package exposing plugin module surface."""
from .module import * # noqa: F401,F403
"""Radio station item type plugin package."""

41
server/app/items/types/radio_station/module.py
View File

@@ -1,41 +0,0 @@
"""Radio item plugin module surface."""
from __future__ import annotations
from .actions import use_item
from .definition import (
CAPABILITIES,
CHANNEL_OPTIONS,
DEFAULT_PARAMS,
DEFAULT_TITLE,
DIRECTIONAL,
EDITABLE_PROPERTIES,
EFFECT_OPTIONS,
EMIT_RANGE,
EMIT_SOUND,
LABEL,
PROPERTY_METADATA,
TOOLTIP,
USE_COOLDOWN_MS,
USE_SOUND,
)
from .validator import validate_update
__all__ = [
"LABEL",
"TOOLTIP",
"EDITABLE_PROPERTIES",
"CAPABILITIES",
"USE_SOUND",
"EMIT_SOUND",
"USE_COOLDOWN_MS",
"EMIT_RANGE",
"DIRECTIONAL",
"DEFAULT_TITLE",
"DEFAULT_PARAMS",
"PROPERTY_METADATA",
"CHANNEL_OPTIONS",
"EFFECT_OPTIONS",
"validate_update",
"use_item",
]

5
server/app/items/types/radio_station/plugin.py
View File

@@ -2,10 +2,11 @@
from __future__ import annotations
from . import module
from ..plugin_helpers import build_item_module
from . import actions, definition, validator
ITEM_TYPE_PLUGIN = {
"type": "radio_station",
"order": 40,
"module": module,
"module": build_item_module(definition, validate_update=validator.validate_update, use_item=actions.use_item),
}

4
server/app/items/types/wheel/__init__.py
View File

@@ -1,3 +1 @@
"""Item type package exposing plugin module surface."""
from .module import * # noqa: F401,F403
"""Wheel item type plugin package."""

37
server/app/items/types/wheel/module.py
View File

@@ -1,37 +0,0 @@
"""Wheel item plugin module surface."""
from __future__ import annotations
from .actions import use_item
from .definition import (
CAPABILITIES,
DEFAULT_PARAMS,
DEFAULT_TITLE,
DIRECTIONAL,
EDITABLE_PROPERTIES,
EMIT_RANGE,
EMIT_SOUND,
LABEL,
PROPERTY_METADATA,
TOOLTIP,
USE_COOLDOWN_MS,
USE_SOUND,
)
from .validator import validate_update
__all__ = [
"LABEL",
"TOOLTIP",
"EDITABLE_PROPERTIES",
"CAPABILITIES",
"USE_SOUND",
"EMIT_SOUND",
"USE_COOLDOWN_MS",
"EMIT_RANGE",
"DIRECTIONAL",
"DEFAULT_TITLE",
"DEFAULT_PARAMS",
"PROPERTY_METADATA",
"validate_update",
"use_item",
]

5
server/app/items/types/wheel/plugin.py
View File

@@ -2,10 +2,11 @@
from __future__ import annotations
from . import module
from ..plugin_helpers import build_item_module
from . import actions, definition, validator
ITEM_TYPE_PLUGIN = {
"type": "wheel",
"order": 50,
"module": module,
"module": build_item_module(definition, validate_update=validator.validate_update, use_item=actions.use_item),
}

4
server/app/items/types/widget/__init__.py
View File

@@ -1,3 +1 @@
"""Item type package exposing plugin module surface."""
from .module import * # noqa: F401,F403
"""Widget item type plugin package."""

39
server/app/items/types/widget/module.py
View File

@@ -1,39 +0,0 @@
"""Widget item plugin module surface."""
from __future__ import annotations
from .actions import use_item
from .definition import (
CAPABILITIES,
DEFAULT_PARAMS,
DEFAULT_TITLE,
DIRECTIONAL,
EDITABLE_PROPERTIES,
EFFECT_OPTIONS,
EMIT_RANGE,
EMIT_SOUND,
LABEL,
PROPERTY_METADATA,
TOOLTIP,
USE_COOLDOWN_MS,
USE_SOUND,
)
from .validator import validate_update
__all__ = [
"LABEL",
"TOOLTIP",
"EDITABLE_PROPERTIES",
"CAPABILITIES",
"USE_SOUND",
"EMIT_SOUND",
"USE_COOLDOWN_MS",
"EMIT_RANGE",
"DIRECTIONAL",
"DEFAULT_TITLE",
"DEFAULT_PARAMS",
"PROPERTY_METADATA",
"EFFECT_OPTIONS",
"validate_update",
"use_item",
]

5
server/app/items/types/widget/plugin.py
View File

@@ -2,10 +2,11 @@
from __future__ import annotations
from . import module
from ..plugin_helpers import build_item_module
from . import actions, definition, validator
ITEM_TYPE_PLUGIN = {
"type": "widget",
"order": 60,
"module": module,
"module": build_item_module(definition, validate_update=validator.validate_update, use_item=actions.use_item),
}

1
server/tests/test_item_plugin_contract.py
View File

@@ -28,5 +28,4 @@ def test_item_plugin_folders_have_required_files() -> None:
assert (type_dir / "definition.py").is_file()
assert (type_dir / "validator.py").is_file()
assert (type_dir / "actions.py").is_file()
assert (type_dir / "module.py").is_file()
assert (type_dir / "plugin.py").is_file()