Dialogue narration and wall tone retrigger fix

Game-file footprint unchanged: still one line in main.lua.

Wall tones: stop the previous tone per direction before playing the new one.
The tones are 2.33s mono; steps land far faster than that and up to four
directions sound at once, so overlapping them stacked into a continuous drone
instead of reading as a per-step cue. Cutting the old tone also means the
distance/volume you hear always reflects where you are standing now.

ingame_dialogue descriptor: speaks speaker and message on a node change, but
only the response on a selection change -- re-reading the whole speech every
time you move between responses would be unusable.

Two more bugs found by the testbed:

4. Nested states.switch announced in reverse. ingame.open() sees
   world.pendingDialogue and switches straight to ingame_dialogue; because we
   announce after realSwitch returns, the inner announcement fired first and the
   outer one interrupted and clobbered it, so entering a conversation said
   'Game' rather than 'Conversation'. Now we stay quiet if we are no longer the
   current state.

5. The game already numbers response text ('1. (Continue)'), matching the number
   key that picks it, so our own numbering produced '1. 1. (Continue)'.

9/9 testbed checks, history unit tests passing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Accessibility Mod
2026-08-01 20:59:04 +02:00
co-authored by Claude Opus 5
parent 9945703fb7
commit da512fc67e
5 changed files with 191 additions and 6 deletions
+11
View File
@@ -29,6 +29,7 @@ local describedStates = {
"load_game",
"new_game",
"narration",
"ingame_dialogue",
}
local initialized = false
@@ -100,6 +101,16 @@ local function hookStates()
-- After the switch, so the state's open() has already set up its focus --
-- main_menu, for one, only picks selectedOption inside open().
pcall(function()
-- Guard against NESTED switches. open() can itself switch state:
-- ingame.open() sees world.pendingDialogue and goes straight to
-- ingame_dialogue. Because we announce after realSwitch returns, the
-- inner announcement ("Conversation") happens first and the outer one
-- ("Game") then interrupts and clobbers it. If we are no longer the
-- current state, the inner switch already announced -- stay quiet.
if states.getCurrent() ~= newState then
return
end
local descriptor = menus.loadDescriptor(newState)
if descriptor then