v3.4: handle-leak fix, Realtek ASIO block, device notifications, quick profile switch, hotkey announcements
Freezes the v3.4 feature set (everything since the v3.3 public release): - Fix the receiver handle leak: the 3-second device-refresh timer reopened the configured ASIO driver every tick, and Realtek's ASIO driver leaks Event+Mutant handles on every open. Cache the ASIO probe per driver so it is opened once. - Realtek ASIO block: detect a Realtek ASIO driver, offer once to disable it, and never touch it again if disabled; Options-menu toggle to reverse. Global config. - Device hot-plug is event-driven (AudioDeviceChangeNotifier) instead of a 3s poll; debounced refresh, falls back to polling if registration fails. - Quick profile switch: new global hotkey opens an NVDA-friendly popup of all profiles (current marked); Enter/click switches; plays a new "profile menu open" cue with Preferences mute + custom-sound. - Announce assigned global hotkeys on the controls/menu items they drive (NVDA reads "press X anywhere"). File > Open already had Ctrl+O. - Held-back changes folded in: config-folder migration, codec-column fix, Tailscale endpoint network-prune, empty-password guard, and the handle-leak diagnostics (ProcessSelfMeter, HandleTypeProbe). Version bumped to 3.4.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Ednunp
co-authored by
Claude Opus 4.8
Claude Opus 4.8
parent
fc451ba3e3
commit
dd70613017
@@ -0,0 +1,151 @@
|
||||
using System.Runtime.InteropServices;
|
||||
|
||||
namespace RemSound.App;
|
||||
|
||||
/// <summary>
|
||||
/// Small, NVDA-friendly pop-up that lists every profile and lets the user switch to one from
|
||||
/// anywhere in Windows — it's opened by the global "Quick profile switch" hotkey. The currently
|
||||
/// loaded profile is marked "(current)" and pre-selected, so the screen reader announces where you
|
||||
/// are the moment it opens. Arrow up/down to browse, Enter or click to switch, Escape to close
|
||||
/// without changing anything. The window forces itself to the foreground so the screen reader lands
|
||||
/// in it even when RemSound is sitting in the tray or another app has focus.
|
||||
/// </summary>
|
||||
internal sealed class QuickProfileSwitchDialog
|
||||
{
|
||||
public sealed record ProfileEntry(string Title, string Path, bool IsCurrent);
|
||||
|
||||
/// <summary>Shows the popup. Returns the chosen profile's path, or null if the user cancelled
|
||||
/// (Escape / Close) or there were no profiles to show.</summary>
|
||||
public static string? Show(IReadOnlyList<ProfileEntry> profiles)
|
||||
{
|
||||
if (profiles.Count == 0) return null;
|
||||
|
||||
using var dialog = new Form
|
||||
{
|
||||
Text = "Quick profile switch",
|
||||
AccessibleName = "Quick profile switch",
|
||||
StartPosition = FormStartPosition.CenterScreen,
|
||||
FormBorderStyle = FormBorderStyle.FixedDialog,
|
||||
MinimizeBox = false,
|
||||
MaximizeBox = false,
|
||||
ShowInTaskbar = false,
|
||||
TopMost = true,
|
||||
KeyPreview = true,
|
||||
ClientSize = new Size(440, 340),
|
||||
};
|
||||
|
||||
var root = new TableLayoutPanel
|
||||
{
|
||||
Dock = DockStyle.Fill,
|
||||
Padding = new Padding(10),
|
||||
ColumnCount = 1,
|
||||
RowCount = 3, // 0 intro, 1 list, 2 close button
|
||||
};
|
||||
root.ColumnStyles.Add(new ColumnStyle(SizeType.Percent, 100));
|
||||
root.RowStyles.Add(new RowStyle(SizeType.AutoSize));
|
||||
root.RowStyles.Add(new RowStyle(SizeType.Percent, 100));
|
||||
root.RowStyles.Add(new RowStyle(SizeType.AutoSize));
|
||||
|
||||
var intro = new Label
|
||||
{
|
||||
Text = "Arrow up and down to a profile, then press Enter to switch to it. Escape closes without changing.",
|
||||
AutoSize = true,
|
||||
MaximumSize = new Size(410, 0),
|
||||
Anchor = AnchorStyles.Left,
|
||||
};
|
||||
root.Controls.Add(intro, 0, 0);
|
||||
|
||||
var list = new ListBox
|
||||
{
|
||||
Dock = DockStyle.Fill,
|
||||
IntegralHeight = false,
|
||||
// NVDA reads this on first focus, then each item's text as the selection moves.
|
||||
AccessibleName = "Profiles",
|
||||
TabIndex = 0,
|
||||
};
|
||||
var currentIndex = 0;
|
||||
for (var i = 0; i < profiles.Count; i++)
|
||||
{
|
||||
var p = profiles[i];
|
||||
list.Items.Add(p.IsCurrent ? $"{p.Title} (current)" : p.Title);
|
||||
if (p.IsCurrent) currentIndex = i;
|
||||
}
|
||||
list.SelectedIndex = currentIndex;
|
||||
root.Controls.Add(list, 0, 1);
|
||||
|
||||
var buttons = new FlowLayoutPanel
|
||||
{
|
||||
Dock = DockStyle.Fill,
|
||||
FlowDirection = FlowDirection.RightToLeft,
|
||||
AutoSize = true,
|
||||
Padding = new Padding(0, 8, 0, 0),
|
||||
};
|
||||
var closeButton = new Button { Text = "Close", AutoSize = true, DialogResult = DialogResult.Cancel, TabIndex = 1 };
|
||||
buttons.Controls.Add(closeButton);
|
||||
root.Controls.Add(buttons, 0, 2);
|
||||
|
||||
dialog.Controls.Add(root);
|
||||
dialog.CancelButton = closeButton;
|
||||
|
||||
string? chosenPath = null;
|
||||
void Commit()
|
||||
{
|
||||
var idx = list.SelectedIndex;
|
||||
if (idx < 0 || idx >= profiles.Count) return;
|
||||
chosenPath = profiles[idx].Path;
|
||||
dialog.DialogResult = DialogResult.OK;
|
||||
dialog.Close();
|
||||
}
|
||||
|
||||
// Enter or a click/double-click on a row switches to it (Ed: "clicking on a profile
|
||||
// switches it"). MouseClick fires after the click has moved the selection, so the clicked
|
||||
// row is the selected one.
|
||||
list.KeyDown += (_, e) =>
|
||||
{
|
||||
if (e.KeyCode == Keys.Enter)
|
||||
{
|
||||
Commit();
|
||||
e.Handled = true;
|
||||
e.SuppressKeyPress = true;
|
||||
}
|
||||
};
|
||||
list.DoubleClick += (_, _) => Commit();
|
||||
list.MouseClick += (_, _) => Commit();
|
||||
|
||||
dialog.KeyDown += (_, e) =>
|
||||
{
|
||||
if (e.KeyCode == Keys.Escape)
|
||||
{
|
||||
dialog.DialogResult = DialogResult.Cancel;
|
||||
dialog.Close();
|
||||
e.Handled = true;
|
||||
e.SuppressKeyPress = true;
|
||||
}
|
||||
};
|
||||
|
||||
dialog.Shown += (_, _) =>
|
||||
{
|
||||
BringToForeground(dialog);
|
||||
list.Focus();
|
||||
};
|
||||
|
||||
var result = dialog.ShowDialog();
|
||||
return result == DialogResult.OK ? chosenPath : null;
|
||||
}
|
||||
|
||||
private static void BringToForeground(Form form)
|
||||
{
|
||||
try
|
||||
{
|
||||
form.Activate();
|
||||
// The hotkey press is recent user input, so the foreground lock lets us call this
|
||||
// (same handshake the tray "restore" uses).
|
||||
SetForegroundWindow(form.Handle);
|
||||
}
|
||||
catch { /* foreground-lock race — best effort, the window is still TopMost */ }
|
||||
}
|
||||
|
||||
[DllImport("user32.dll")]
|
||||
[return: MarshalAs(UnmanagedType.Bool)]
|
||||
private static extern bool SetForegroundWindow(IntPtr hWnd);
|
||||
}
|
||||
Reference in New Issue
Block a user