Talon/RemSound
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ASIO: correct stale close-lifecycle comment after the apartment change

Browse Source 
UpdateSources still claimed the driver "only truly closes on Stop()/Dispose()".
That stopped being true when the apartment made closing safe: the driver now also
closes on ASIO-deselect and driver-switch (AudioSender releases it). Comment-only,
no behaviour or IL change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Ednunp
2026-07-17 17:13:45 +01:00
co-authored by Claude Opus 4.8
parent 7b1eac8df4
commit 7135908339
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/RemSound.Sender/AsioCaptureBackend.cs
+4 -2
View File
@@ -205,8 +205,10 @@ internal sealed class AsioCaptureBackend : ICaptureBackend
// seconds, which is exactly the pattern the user produces by unticking the last // seconds, which is exactly the pattern the user produces by unticking the last
// ASIO source and then ticking another one. Keeping the driver open with zero // ASIO source and then ticking another one. Keeping the driver open with zero
// active pairs makes the callback fire harmlessly (zeros) and the next pair // active pairs makes the callback fire harmlessly (zeros) and the next pair
// addition takes effect on the very next callback. The driver only truly closes // addition takes effect on the very next callback. Toggling pairs never closes the
// on Stop() or Dispose(), which fire on sender disabled or app exit. // driver; the actual close happens elsewhere — Stop()/Dispose() (sender disabled or
// app exit) and AudioSender releasing the driver when ASIO is deselected or the user
// picks a different driver — all of which are now safe on the apartment thread.
activeChannelPairIndices = newPairs; activeChannelPairIndices = newPairs;
onDiagnostic?.Invoke($"asio capture: pairs updated to [{string.Join(",", activeChannelPairIndices)}] (no driver restart)"); onDiagnostic?.Invoke($"asio capture: pairs updated to [{string.Join(",", activeChannelPairIndices)}] (no driver restart)");
} }