Talon/RemSound
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bump to v1.5.0: cross-lane routing fix, recording double-tap fix, menu reorg

Browse Source 
Bug fixes:
* BothIndependent recording was double-tapped — when both WASAPI and
  ASIO outputs were ticked, recordings came out garbled and ~2x the
  expected duration. AudioRecorder now uses four per-lane rings
  (sent-wasapi, sent-asio, recv-wasapi, recv-asio) plus a writer-
  thread mix step that drains min(wasapi, asio) frames and sum-mixes
  with the soft-tanh limiter. Tap signatures gained a RenderRoute
  parameter; Mixed maps to the wasapi slot.
* A peer announcing on the WASAPI lane was inaudible when the
  receiver only had an ASIO output ticked (and vice versa). The
  session opened, samples flowed into the SessionPlayout ring, but
  ReadForRoute(AsioLane) skipped any session whose Route was
  WasapiLane so nothing drained the ring. PlayoutEngine now tracks
  per-lane "is this lane backed by a device" via volatile bools
  settable through SetLaneActive(RenderRoute, bool), called from
  CompositeRenderBackend.SetOutputDevices whenever the device split
  changes. ReadForRoute admits orphan sessions when the other lane
  is inactive.

Menu reorganisation:
* New Options menu (Alt+O) holds Recording settings (Alt+S), Keyboard
  shortcuts (Alt+K, Ctrl+K), Startup behaviour (Alt+T), Preferences
  (Alt+P, Ctrl+P). Pre-v1.5 these were scattered across File menu,
  Record menu, and inside the Preferences dialog itself.
* Record menu mnemonic moved from Alt+O to Alt+K, rendered as
  "Record (Alt+K)" so the chord is visible despite K not being a
  letter in "Record". Alt+R is taken by Receive audio.
* File menu — new Recent profiles submenu (Alt+F, R) listing the
  five most-recently-opened profiles. Press 1..5 inside the submenu
  to jump to a slot. Missing files are skipped from the menu but
  kept in storage.
* Rename current profile moves to Alt+M (was R), Minimise to tray
  moves to Alt+N (was M).
* Lock to audio clock was Alt+K, now Alt+D.

UX additions:
* Ctrl+O = Open profile (matches the menu chord).
* New global hotkey: Start / Stop recording. Pickable from Options
  -> Keyboard shortcuts. Unbound by default. Works system-wide.

Wire format and audio pipeline unchanged from v1.4 — v1.4 and v1.5
peers interoperate.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Ednunp
2026-05-15 17:20:01 +01:00
co-authored by Claude Opus 4.7
parent b96ba82378
commit 4915a9afe1
16 changed files with 721 additions and 218 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/RemSound.App/MainFormHotkeyController.cs
+46 -12
View File
@@ -11,6 +11,11 @@ internal sealed class MainFormHotkeyController : IDisposable
private readonly Action toggleTray;
private readonly Action volumeUp;
private readonly Action volumeDown;
// Toggle recording — fires the same ToggleRecording path the Record menu item and the
// in-app Ctrl+R shortcut hit. The in-app Ctrl+R only fires when MainForm has focus; this
// hotkey works system-wide via RegisterHotKey. Default binding is unset so we don't
// collide with anything on a fresh install — users who want it pick their own combo.
private readonly Action toggleRecording;
// Remote control hotkeys: trigger this machine to send a Control packet to its connected
// peers. The local volume slider on this machine isn't touched — receivers that have opted
// in handle the change. See Profile.AcceptRemoteVolumeCommands and the RemPacketType.Control
@@ -31,6 +36,7 @@ internal sealed class MainFormHotkeyController : IDisposable
private HotkeyInfo trayHotkey;
private HotkeyInfo volumeUpHotkey;
private HotkeyInfo volumeDownHotkey;
private HotkeyInfo toggleRecordingHotkey;
private HotkeyInfo remoteVolumeUpHotkey;
private HotkeyInfo remoteVolumeDownHotkey;
private HotkeyInfo remoteMuteToggleHotkey;
@@ -42,6 +48,7 @@ internal sealed class MainFormHotkeyController : IDisposable
private GlobalHotkey? trayGlobalHotkey;
private GlobalHotkey? volumeUpGlobalHotkey;
private GlobalHotkey? volumeDownGlobalHotkey;
private GlobalHotkey? toggleRecordingGlobalHotkey;
private GlobalHotkey? remoteVolumeUpGlobalHotkey;
private GlobalHotkey? remoteVolumeDownGlobalHotkey;
private GlobalHotkey? remoteMuteToggleGlobalHotkey;
@@ -70,6 +77,7 @@ internal sealed class MainFormHotkeyController : IDisposable
Action toggleTray,
Action volumeUp,
Action volumeDown,
Action toggleRecording,
Action sendRemoteVolumeUp,
Action sendRemoteVolumeDown,
Action sendRemoteMuteToggle,
@@ -83,6 +91,7 @@ internal sealed class MainFormHotkeyController : IDisposable
this.toggleTray = toggleTray;
this.volumeUp = volumeUp;
this.volumeDown = volumeDown;
this.toggleRecording = toggleRecording;
this.sendRemoteVolumeUp = sendRemoteVolumeUp;
this.sendRemoteVolumeDown = sendRemoteVolumeDown;
this.sendRemoteMuteToggle = sendRemoteMuteToggle;
@@ -94,6 +103,7 @@ internal sealed class MainFormHotkeyController : IDisposable
trayHotkey = settingsStore.LoadTrayHotkey();
volumeUpHotkey = settingsStore.LoadVolumeUpHotkey();
volumeDownHotkey = settingsStore.LoadVolumeDownHotkey();
toggleRecordingHotkey = settingsStore.LoadToggleRecordingHotkey();
remoteVolumeUpHotkey = settingsStore.LoadRemoteVolumeUpHotkey();
remoteVolumeDownHotkey = settingsStore.LoadRemoteVolumeDownHotkey();
remoteMuteToggleHotkey = settingsStore.LoadRemoteMuteToggleHotkey();
@@ -110,6 +120,7 @@ internal sealed class MainFormHotkeyController : IDisposable
trayGlobalHotkey = new GlobalHotkey(ownerForm);
volumeUpGlobalHotkey = new GlobalHotkey(ownerForm);
volumeDownGlobalHotkey = new GlobalHotkey(ownerForm);
toggleRecordingGlobalHotkey = new GlobalHotkey(ownerForm);
remoteVolumeUpGlobalHotkey = new GlobalHotkey(ownerForm);
remoteVolumeDownGlobalHotkey = new GlobalHotkey(ownerForm);
remoteMuteToggleGlobalHotkey = new GlobalHotkey(ownerForm);
@@ -121,6 +132,7 @@ internal sealed class MainFormHotkeyController : IDisposable
trayGlobalHotkey.Pressed += () => InvokeOnOwner(toggleTray);
volumeUpGlobalHotkey.Pressed += () => InvokeOnOwner(volumeUp);
volumeDownGlobalHotkey.Pressed += () => InvokeOnOwner(volumeDown);
toggleRecordingGlobalHotkey.Pressed += () => InvokeOnOwner(toggleRecording);
remoteVolumeUpGlobalHotkey.Pressed += () => InvokeOnOwner(sendRemoteVolumeUp);
remoteVolumeDownGlobalHotkey.Pressed += () => InvokeOnOwner(sendRemoteVolumeDown);
remoteMuteToggleGlobalHotkey.Pressed += () => InvokeOnOwner(sendRemoteMuteToggle);
@@ -132,6 +144,7 @@ internal sealed class MainFormHotkeyController : IDisposable
RegisterTrayHotkey();
RegisterVolumeUpHotkey();
RegisterVolumeDownHotkey();
RegisterToggleRecordingHotkey();
RegisterRemoteVolumeUpHotkey();
RegisterRemoteVolumeDownHotkey();
RegisterRemoteMuteToggleHotkey();
@@ -229,11 +242,17 @@ internal sealed class MainFormHotkeyController : IDisposable
var prev = list.SelectedIndex;
list.BeginUpdate();
list.Items.Clear();
// Order matches the case-block dispatchers in ChangeSelected and UnsetSelected
// below. Local-action hotkeys first (rows 0..5: send / receive / tray / volume×2 /
// recording), then the remote-app trio (rows 6..8), then the Windows-system trio
// (rows 9..11). Toggle recording joined the local group at index 5 in v1.5
// (2026-05-15) — natural fit alongside the other "this machine" toggles.
list.Items.Add($"Toggle sending audio: {sendMuteHotkey}");
list.Items.Add($"Toggle receiving audio: {receiveMuteHotkey}");
list.Items.Add($"Show or hide window: {trayHotkey}");
list.Items.Add($"Volume up for received sound on this machine: {volumeUpHotkey}");
list.Items.Add($"Volume down for received sound on this machine: {volumeDownHotkey}");
list.Items.Add($"Start / Stop recording: {toggleRecordingHotkey}");
list.Items.Add($"Send remote volume up to peers: {remoteVolumeUpHotkey}");
list.Items.Add($"Send remote volume down to peers: {remoteVolumeDownHotkey}");
list.Items.Add($"Send remote receive mute toggle to peers: {remoteMuteToggleHotkey}");
@@ -269,12 +288,13 @@ internal sealed class MainFormHotkeyController : IDisposable
case 2: ChangeTrayHotkey(dialog); break;
case 3: ChangeVolumeUpHotkey(dialog); break;
case 4: ChangeVolumeDownHotkey(dialog); break;
case 5: ChangeRemoteVolumeUpHotkey(dialog); break;
case 6: ChangeRemoteVolumeDownHotkey(dialog); break;
case 7: ChangeRemoteMuteToggleHotkey(dialog); break;
case 8: ChangeSystemVolumeUpHotkey(dialog); break;
case 9: ChangeSystemVolumeDownHotkey(dialog); break;
case 10: ChangeSystemMuteToggleHotkey(dialog); break;
case 5: ChangeToggleRecordingHotkey(dialog); break;
case 6: ChangeRemoteVolumeUpHotkey(dialog); break;
case 7: ChangeRemoteVolumeDownHotkey(dialog); break;
case 8: ChangeRemoteMuteToggleHotkey(dialog); break;
case 9: ChangeSystemVolumeUpHotkey(dialog); break;
case 10: ChangeSystemVolumeDownHotkey(dialog); break;
case 11: ChangeSystemMuteToggleHotkey(dialog); break;
default: return;
}
RefreshList();
@@ -299,12 +319,13 @@ internal sealed class MainFormHotkeyController : IDisposable
case 2: ApplyUnset("tray", h => trayHotkey = h, RegisterTrayHotkey, settingsStore.SaveTrayHotkey); break;
case 3: ApplyUnset("volume-up", h => volumeUpHotkey = h, RegisterVolumeUpHotkey, settingsStore.SaveVolumeUpHotkey); break;
case 4: ApplyUnset("volume-down", h => volumeDownHotkey = h, RegisterVolumeDownHotkey, settingsStore.SaveVolumeDownHotkey); break;
case 5: ApplyUnset("send-remote-volume-up", h => remoteVolumeUpHotkey = h, RegisterRemoteVolumeUpHotkey, settingsStore.SaveRemoteVolumeUpHotkey); break;
case 6: ApplyUnset("send-remote-volume-down", h => remoteVolumeDownHotkey = h, RegisterRemoteVolumeDownHotkey, settingsStore.SaveRemoteVolumeDownHotkey); break;
case 7: ApplyUnset("send-remote-mute-toggle", h => remoteMuteToggleHotkey = h, RegisterRemoteMuteToggleHotkey, settingsStore.SaveRemoteMuteToggleHotkey); break;
case 8: ApplyUnset("send-system-volume-up", h => systemVolumeUpHotkey = h, RegisterSystemVolumeUpHotkey, settingsStore.SaveSystemVolumeUpHotkey); break;
case 9: ApplyUnset("send-system-volume-down", h => systemVolumeDownHotkey = h, RegisterSystemVolumeDownHotkey, settingsStore.SaveSystemVolumeDownHotkey); break;
case 10: ApplyUnset("send-system-mute-toggle", h => systemMuteToggleHotkey = h, RegisterSystemMuteToggleHotkey, settingsStore.SaveSystemMuteToggleHotkey); break;
case 5: ApplyUnset("toggle-recording", h => toggleRecordingHotkey = h, RegisterToggleRecordingHotkey, settingsStore.SaveToggleRecordingHotkey); break;
case 6: ApplyUnset("send-remote-volume-up", h => remoteVolumeUpHotkey = h, RegisterRemoteVolumeUpHotkey, settingsStore.SaveRemoteVolumeUpHotkey); break;
case 7: ApplyUnset("send-remote-volume-down", h => remoteVolumeDownHotkey = h, RegisterRemoteVolumeDownHotkey, settingsStore.SaveRemoteVolumeDownHotkey); break;
case 8: ApplyUnset("send-remote-mute-toggle", h => remoteMuteToggleHotkey = h, RegisterRemoteMuteToggleHotkey, settingsStore.SaveRemoteMuteToggleHotkey); break;
case 9: ApplyUnset("send-system-volume-up", h => systemVolumeUpHotkey = h, RegisterSystemVolumeUpHotkey, settingsStore.SaveSystemVolumeUpHotkey); break;
case 10: ApplyUnset("send-system-volume-down", h => systemVolumeDownHotkey = h, RegisterSystemVolumeDownHotkey, settingsStore.SaveSystemVolumeDownHotkey); break;
case 11: ApplyUnset("send-system-mute-toggle", h => systemMuteToggleHotkey = h, RegisterSystemMuteToggleHotkey, settingsStore.SaveSystemMuteToggleHotkey); break;
default: return;
}
RefreshList();
@@ -377,6 +398,7 @@ internal sealed class MainFormHotkeyController : IDisposable
trayGlobalHotkey?.Dispose();
volumeUpGlobalHotkey?.Dispose();
volumeDownGlobalHotkey?.Dispose();
toggleRecordingGlobalHotkey?.Dispose();
remoteVolumeUpGlobalHotkey?.Dispose();
remoteVolumeDownGlobalHotkey?.Dispose();
remoteMuteToggleGlobalHotkey?.Dispose();
@@ -390,6 +412,7 @@ internal sealed class MainFormHotkeyController : IDisposable
public HotkeyInfo TrayHotkey => trayHotkey;
public HotkeyInfo VolumeUpHotkey => volumeUpHotkey;
public HotkeyInfo VolumeDownHotkey => volumeDownHotkey;
public HotkeyInfo ToggleRecordingHotkey => toggleRecordingHotkey;
public HotkeyInfo RemoteVolumeUpHotkey => remoteVolumeUpHotkey;
public HotkeyInfo RemoteVolumeDownHotkey => remoteVolumeDownHotkey;
public HotkeyInfo RemoteMuteToggleHotkey => remoteMuteToggleHotkey;
@@ -478,6 +501,13 @@ internal sealed class MainFormHotkeyController : IDisposable
settingsStore.SaveVolumeDownHotkey(h);
});
private void ChangeToggleRecordingHotkey(IWin32Window dialogOwner) => ChangeHotkey(dialogOwner, "toggle-recording", h =>
{
toggleRecordingHotkey = h;
RegisterToggleRecordingHotkey();
settingsStore.SaveToggleRecordingHotkey(h);
});
private void ChangeRemoteVolumeUpHotkey(IWin32Window dialogOwner) => ChangeHotkey(dialogOwner, "send-remote-volume-up", h =>
{
remoteVolumeUpHotkey = h;
@@ -535,6 +565,10 @@ internal sealed class MainFormHotkeyController : IDisposable
private void RegisterTrayHotkey() => RegisterIfSet(trayGlobalHotkey, trayHotkey, "tray");
private void RegisterVolumeUpHotkey() => RegisterIfSet(volumeUpGlobalHotkey, volumeUpHotkey, "volume up", allowRepeat: true);
private void RegisterVolumeDownHotkey() => RegisterIfSet(volumeDownGlobalHotkey, volumeDownHotkey, "volume down", allowRepeat: true);
// Toggle recording is a one-shot toggle (press → flip Start/Stop). MOD_NOREPEAT
// (allowRepeat: false, the default) prevents a held key from flipping the recording
// state on/off/on/off at keyboard auto-repeat rate.
private void RegisterToggleRecordingHotkey() => RegisterIfSet(toggleRecordingGlobalHotkey, toggleRecordingHotkey, "toggle recording");
private void RegisterRemoteVolumeUpHotkey() => RegisterIfSet(remoteVolumeUpGlobalHotkey, remoteVolumeUpHotkey, "send remote volume up", allowRepeat: true);
private void RegisterRemoteVolumeDownHotkey() => RegisterIfSet(remoteVolumeDownGlobalHotkey, remoteVolumeDownHotkey, "send remote volume down", allowRepeat: true);
private void RegisterRemoteMuteToggleHotkey() => RegisterIfSet(remoteMuteToggleGlobalHotkey, remoteMuteToggleHotkey, "send remote mute toggle");